https://bugzilla.redhat.com/show_bug.cgi?id=1662565



--- Comment #1 from Michael Schwendt <[email protected]> ---
> License:    GPLv3+

Files say "GPLv3" only. No "or later" in any source files.

[!] Source tarball contains bundled projects covered by different license
terms. Such as protobuf-c. This will need a close look.


> BuildRequires: gcc-c++

Doesn't seem to be true, since a plain C lib is built from C code.


> Requires:   libsignal-protocol-c == %{version}

The base package guidelines haven't been changed:
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> Requires:   pkgconf-pkg-config

Very unusual and should be removed in favor of rpmbuild's automatic dependency
on pkg-config.


> %changelog

Out of sync.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to