https://bugzilla.redhat.com/show_bug.cgi?id=1663586



--- Comment #4 from Dominik 'Rathann' Mierzejewski <[email protected]> ---
(In reply to Elliott Sales de Andrade from comment #3)
> The description states "Kaitai Struct is a declarative language used for
> describe ..." which has some sort of verb mismatch. s/for/to/ maybe?
> You may also want to ask upstream to provide a separate LICENSE file. I know
> it's in the readme, but a separate file is easier to find (plus it works
> with GitHub's automatic license tag.)
> 
> 
> Otherwise, approved.

Thanks for the review, Elliott.

I'll fix the description. There are already several issues open upstream asking
to include the license texts explicitly:
https://github.com/kaitai-io/kaitai_struct/issues/474
https://github.com/kaitai-io/kaitai_struct/issues/265
https://github.com/kaitai-io/kaitai_struct/issues/264

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to