https://bugzilla.redhat.com/show_bug.cgi?id=1672313

Jitka Plesnikova <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <[email protected]> ---
Please correct all 'FIX' issues.
Otherwise the package looks good.
Approved

Source file is ok
Summary is ok
License is ok
Description is ok

Source0 are ok
FIX: Please update URL to use link to metacpan.org
     https://metacpan.org/release/Perl-PrereqScanner-NotQuiteLite

All tests passed

BuildRequires are almost ok
FIX: Please add 'perl(if)' - t/Util.pm:12, t/scan/Util.pm:8

$ rpm -qp --requires
perl-Perl-PrereqScanner-NotQuiteLite-0.9903-1.fc30.noarch.rpm | grep -v
'rpmlib' |sort | uniq -c
      1 perl(Carp)
      1 perl(constant)
      1 perl(CPAN::Meta::Prereqs)
      1 perl(CPAN::Meta::Requirements)
      1 perl(Data::Dump)
      1 perl(Exporter) >= 5.57
      1 perl(File::Basename)
      1 perl(File::Find)
      1 perl(File::Spec)
      1 perl(Getopt::Long)
      1 perl(JSON::PP)
      1 perl(lib)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(Module::CoreList)
      1 perl(Module::CPANfile)
      1 perl(Module::Find)
      1 perl(parent)
      1 perl(Perl::PrereqScanner::NotQuiteLite)
      1 perl(Perl::PrereqScanner::NotQuiteLite::App)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Context)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Util)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Util::Prereqs)
      1 perl(Pod::Usage)
      1 perl(Regexp::Trie)
      1 perl(strict)
      1 perl(warnings)
      1 /usr/bin/perl
Binary requires are Ok.

$ rpm -qp --provides
perl-Perl-PrereqScanner-NotQuiteLite-0.9903-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Perl::PrereqScanner::NotQuiteLite) = 0.9903
      1 perl-Perl-PrereqScanner-NotQuiteLite = 0.9903-1.fc30
      1 perl(Perl::PrereqScanner::NotQuiteLite::App)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Context)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Aliased)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::AnyMoose)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Autouse)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Catalyst)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::ClassAccessor)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::ClassAutouse)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::ClassLoad)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Core)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Inline)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::KeywordDeclare)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Later)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Mixin)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::ModuleRuntime)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::MojoBase)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Moose)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::MooseXDeclare)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Only)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::PackageVariant)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Plack)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::POE)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Prefork)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Superclass)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Syntax)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::SyntaxCollector)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::TestClassMost)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::TestMore)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::TestRequires)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::UniversalVersion)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Unless)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Tokens)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Util)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Util::CPANfile)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Util::Prereqs)
Binary provides are Ok.

$ rpmlint ./perl-Perl-PrereqScanner-NotQuiteLite*
perl-Perl-PrereqScanner-NotQuiteLite.noarch: W: spelling-error %description -l
en_US ExtractUse -> Extract Use, Extract-use, Extract
perl-Perl-PrereqScanner-NotQuiteLite.noarch: W: spelling-error %description -l
en_US eval -> veal, vela, val
perl-Perl-PrereqScanner-NotQuiteLite.src: W: spelling-error %description -l
en_US ExtractUse -> Extract Use, Extract-use, Extract
perl-Perl-PrereqScanner-NotQuiteLite.src: W: spelling-error %description -l
en_US eval -> veal, vela, val
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Rpmlint is ok

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to