https://bugzilla.redhat.com/show_bug.cgi?id=1402656



--- Comment #8 from Michael Hampton <[email protected]> ---
(In reply to Robert-André Mauchin from comment #7)
>  - Not needed:
> 
> %defattr(-,root,root)
> 
> %attr(755,root,root) 
> 
>    It is the default already.
> 
>  - Build are by default hardened as well: %global _hardened_build 1
> 
>  - use %set_build_flags to set Fedora default flags:
> 
> %build
> %set_build_flags
> %make_build
> 
>  - Give your archive a better name:
> 
> Source:
> https://github.com/TargetHolding/%{name}/archive/v%{version}/%{name}-
> %{version}.tar.gz

Spec URL: https://error.fedorapeople.org/bdsync.spec
SRPM URL: https://error.fedorapeople.org/bdsync-0.10.2-2.fc29.src.rpm

All of these changes have been made now, in 0.10.2-2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to