https://bugzilla.redhat.com/show_bug.cgi?id=1659556

Martin Pitt <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([email protected]
                   |                            |)



--- Comment #7 from Martin Pitt <[email protected]> ---
>  - You need to add a comment detailing how to generate the archive

Is "archive" the upstream tarball? These get published on GitHub with some
upstream machinery, but usually downstream we don't document how upstream does
releases.
What do you mean by this?

> - You need to validate the metainfo data: 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
> - add a %changelog section

Good points, thank you! Fixed in https://github.com/weldr/welder-web/pull/534
and I'll do a new release later today, and will provide new COPR links.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to