Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=648465 Remi Collet <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] AssignedTo|[email protected] |[email protected] Flag| |fedora-review? --- Comment #1 from Remi Collet <[email protected]> 2010-11-06 04:02:10 EDT --- Notes before review 1/ Don't use %channel for a package from default pear channel Provides: php-pear(%{pear_name}) = %{version} 2/ License is not BSD but MIT 3/ Reduce path of /usr/share/doc/php-pear-Console-CommandLine-1.1.3/Console_CommandLine/docs/examples To /usr/share/doc/php-pear-Console-CommandLine-1.1.3/examples 4/ add a %check section to run test suite %check cd %{pear_name}-%{version} PHPRC=./php.ini %{__pear} run-tests tests | tee tests.log # run-tests doesn't set return code, so grep it grep "FAILED TESTS" tests.log && exit 1 OR %check cd %{pear_name}-%{version} %{_bindir}/phpunit tests I prefer the "phpunit" version, which set the return code and display failing tests output. But which need additional BR php-pear(pear.phpunit.de/PHPUnit) Build in mock (with %check) is ok. 5/ must own %{pear_phpdir}/Console -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
