https://bugzilla.redhat.com/show_bug.cgi?id=1671790
--- Comment #5 from Miro Hrončok <[email protected]> --- A suggestion about python_to_python3.patch: Don't change "python" to "python3", change it to sys.executable and propose that change upstream. You can link to https://www.python.org/dev/peps/pep-0394/#recommendation > When reinvoking the interpreter from a Python script, querying sys.executable > to avoid hardcoded assumptions regarding the interpreter location remains the > preferred approach. ------ # this is optional but tests for spinners are failing because of that so I decided to make that hard requires It is not uncommon that tests need also optional dependencies. Reading the code in https://github.com/sarugaku/vistir/blob/master/src/vistir/spin.py I suggest you use Recommends instead of Requires. ------ Any particular reason to mix python3dist(xxx) and python3-xxx in BuildRequires? I stick to one. Also, the #for tests comment is kinda weird, aren't others also needed for tests? ------ # one test require internet to pass %bcond_without internet ... %if %{with internet} -k 'not test_open_file' %endif This feels like a reverted logic. When I use "--without internet" the test that requires internet will run, while when I use "--with internet" the test that requires internet won't run. (Bconds are confusing.) What about this instead: # one test requires internet connection, we deselect it by default unless --with internet is used %bcond_with internet ... %if %{without internet} -k 'not test_open_file' %endif -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
