https://bugzilla.redhat.com/show_bug.cgi?id=1666493



--- Comment #3 from Robert-AndrĂ© Mauchin <[email protected]> ---
This package doesn't conform to the the Fedora Packaging Guidelines, you should
read them
https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/ 
https://docs.fedoraproject.org/en-US/packaging-guidelines/

 - Not needed:

%define _topdir    
/home/travis/build/was-lighthouse/openliberty-rpmdeb/rpmbuild
%define name        openliberty
%define version     18.0.0.4
%define buildroot   %{_topdir}/BUILDROOT/%{name}-root

 - Shouldn't be used:

#%define _rpmfilename %%{NAME}-%%{VERSION}.%%{ARCH}.rpm

AutoProv: no
%undefine __find_provides
AutoReq: no
%undefine __find_requires
# Do not try autogenerate prereq/conflicts/obsoletes and check files
%undefine __check_files
%undefine __find_prereq
%undefine __find_conflicts
%undefine __find_obsoletes
# Be sure buildpolicy set to do nothing - does not randomly compile the python
files
%define __spec_install_post %{nil}
# Remove missing file termination
%define _missing_doc_files_terminate_build 0

#BUILDHOST:     IBM Linux Machine
#OS:            linux
#ARCH:          noarch

 - Not needed

BuildRoot:      %{buildroot}
Group:          WAS/Development/Tools
Vendor:         IBM
Packager:       IBM

 - Missing dist tag:

Release:        1%{?dist}

 - Description should be split to be under 80 characters per line

 - The package should not be installed inder /opt

"All architecture-independent JAR files MUST go into %{_javadir} or its
subdirectory."

 - You should provide SystemD files, not init.d ones

 - You need to include a changelog entry

 - It is forbidden to ship jar files directly:

https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_pre_built_dependencies

https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#prebuilt-binaries-or-libraries

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to