https://bugzilla.redhat.com/show_bug.cgi?id=1686023

Petr Menšík <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Petr Menšík <[email protected]> ---
Interesting package. Non format review yet.

However it should be adapted to Fedora system more. For example /etc/default is
not usually used on Fedora, instead similar purposes have /etc/sysconfig
directory.

I think %{_sysconfdir}/console-setup should be %config(noreplace) too, or it
should be moved to %{_datadir}. Ideally if system distributed file was in
%_datadir and user could modify its copy in %_sysconfdir.

I think your spec does not conform to FontPolicy [1]. Fonts should be packaged
separate from any other tools or code.
 As an example take kbd package and terminus-console-fonts package with only
fonts.

1. https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to