https://bugzilla.redhat.com/show_bug.cgi?id=1686506



--- Comment #2 from Lubomir Rintel <[email protected]> ---
Thanks, this looks fairly good.

A couple of questions:

1.) Why do you call the package lowercase "wireguard"? Upstream seems to call
the thing "WireGuard"

2.) What's the use of this in Fedora?

> Provides:       %{name}-kmod-common = %{version}
> %if 0%{?fedora} || 0%{?rhel} > 7
> Suggests:       %{name}-kmod >= %{version}
> %endif

The Fedora kernel-core package seems to provide "kmod(<module>.ko)" for the
modules it ships. I guess that "kmod(wireguard.ko)" is what we should depend
on? Though I suppose only a weak dependency would do until the kernel actually
ships the module.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to