https://bugzilla.redhat.com/show_bug.cgi?id=1690185



--- Comment #4 from Nathan Scott <[email protected]> ---
(In reply to Robert-André Mauchin from comment #3)
>  - Do not require Go deps like this:

OK - will do.  (for my education, what's the reason for one way over the other?
 or is there somewhere I can read about it?  taa)

> BuildRequires:  golang-gopkg-ini-1-devel

Also - should these golang packages with the versioned gopkg.in variants have
spec file names containing an explicit version number?  (in case someone
packages a different version later?)  i.e. for this review, should I have named
the file 'golang-github-macaron-1.spec' or perhaps
'golang-github-macaron-v1.spec'?  (or something else entirely?)

> You should use the Gofed tool to create draft of the SPEC not do them
> manually.

Thanks - I'll take another look.  I didn't have alot of success with gofed
initially (based on steps in the fedora wiki docs) and got the impression it
was out of favour.

cheers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to