https://bugzilla.redhat.com/show_bug.cgi?id=1695373



--- Comment #1 from [email protected] ---
A few comments:

- you can drop the %{python3_pkgversion} macro, as that evaluates to 3

- don't hardcode the manual page's file extension in %files:
%{_mandir}/man1/%{srcname}.1.gz => %{_mandir}/man1/%{srcname}.1.*

- you can use the %py3_dist macro to pull in python packages like this: 
  BuildRequires:  %{py3_dist sphinx}

- consider defining the description text via a separate macro, so that you
don't have to copy&paste it

- I'll check whether it's ok to include the README.md as %license, but consider
reporting this as an issue upstream anyway

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to