https://bugzilla.redhat.com/show_bug.cgi?id=1670656
--- Comment #37 from Xavier Bachelot <[email protected]> --- The diff between the very first spec in this review and what it is now is really impressive, well done. More nitpicking, you're used to it now ;-) - Patch0 can probably be split in several pieces and part of them upstream'ed (manpages and file perms changes at least seem relevant) - Still about the patch, why change PLUGINS_DIR to /var/lib/grafana/data/plugins instead of /var/lib/grafana/plugins ? - For legibility, can the lua script be moved at the top of the spec and just the results be used in the ExclusiveArch tag ? - You can use %{?systemd_requires} in place of the explicit Requires(pre/post/postun): systemd - About Provides: bundled(golang-github-grafana-grafana-plugin-model-devel) = 0.0.1 if this is part of grafana, then this is not bundled. - There used to be Provides: bundled(..) for all the golang stuff in the bundle everything case (fedora <= 28 or EL <= 7). I think it should be put back in case you want to build for EL7 (I guess F28 doesn't really matter anymore). - Why "chmod 644 %{SOURCE2} # silence an rpmlint non-issue" in %install ? The file is already 644 in the srpm. Last point is I'm not sure how much I like the enormous pile of bundled nodejs stuff, but this is again an huge task and it seems to be somewhat accepted, so... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
