https://bugzilla.redhat.com/show_bug.cgi?id=1698871

Robert-André Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #3 from Robert-André Mauchin <[email protected]> ---
 - Group: is not used in Fedora

 - Please split you BR/RR one per line for clarity

 - Missing isa:

Requires: supercollider%{?_isa} = %{version}-%{release}

 - Use the default %cmake macro instead of cobbling your own

export CFLAGS="%{build_cflags} -fext-numeric-literals" 
export CXXFLAGS="%{build_cxxflags} -fext-numeric-literals"
%cmake -DCMAKE_SKIP_RPATH:BOOL=ON \
       -DSYSTEM_BOOST=ON \
       -DCMAKE_BUILD_TYPE=Release \
       -DCMAKE_VERBOSE_MAKEFILE=TRUE \
       %{cmakearch} %{?geditver} \
       ..

 - make %{?_smp_mflags} → %make_build

 - make install DESTDIR=%{buildroot} → %make_install

 - The license file must be installed with %license, mot %doc:

%doc README*
%license COPYING

 - .desktop files must be validated, see
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage


desktop-file-validate
%{buildroot}/%{_datadir}/applications/SuperColliderIDE.desktop

 - Own %{_datadir}/SuperCollider

%dir %{_datadir}/SuperCollider

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to