https://bugzilla.redhat.com/show_bug.cgi?id=1701013
Carl George <carl@george.computer> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |carl@george.computer
Assignee|nob...@fedoraproject.org |carl@george.computer
Flags| |fedora-review?
--- Comment #4 from Carl George <carl@george.computer> ---
Richard, I looked through the history of this in bug 1634658 to get up to
speed. Thanks for your hard work on this so far. You said you've fixed those
things Miro pointed out, but your original spec file link doesn't have those
fixes. Is it at a new URL now?
Can you adjust your globs in %files to be more specific? Perhaps something
like:
-%{_libdir}/libpyside2*.so.*
+%{_libdir}/libpyside2*.so.5.12*
-%{_libdir}/libshiboken2*.so.*
+%{_libdir}/libshiboken2*.so.5.12*
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files
I also agree with Miro's previous point about filtering the autoprovides (bug
1634658, comment 90). I checked a few other arched python modules, and none of
them provide their sonames from within %{python3_sitearch}.
https://docs.fedoraproject.org/en-US/packaging-guidelines/AutoProvidesAndRequiresFiltering/#_summary
> Packages must not provide RPM dependency information when that information is
> not global in nature
Since libpyside2.cpython-37m-x86_64-linux-gnu.so.5.12 and
libshiboken2.cpython-37m-x86_64-linux-gnu.so.5.12 are not global in nature I
think they should be filtered out. As further evidence of this, rpmlint
expects python3-shiboken2-devel to explicitly require python3-shiboken2-libs.
> python3-shiboken2-devel.x86_64: W: no-dependency-on
> python3-shiboken2/python3-shiboken2-libs/libpython3-shiboken2
I would filter out the automatic libshiboken2 provides/requires and explicitly
require the necessary packages.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
