Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652758 Matthias Clasen <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #5 from Matthias Clasen <[email protected]> 2010-11-12 13:17:03 EST --- Formal review (following https://fedoraproject.org/wiki/Packaging:ReviewGuidelines) package name: ok spec file name: ok packaging guidelines ok license: ok license field: ok license file: ok spec file language: ok spec file legibility: ok upstream sources: ok buildable: ok excludearch: ok buildrequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: ok directory ownership: ok duplicate files: ok file permissions: ok macro use: ok permissible content: ok large docs: ok %doc contenet: ok headers: ok static libs: ok shared libs: ok -devel deps: ok libtool archives: ok gui apps: ok duplicate ownership: ok utf8 filenames: ok Looks good, just a minor cosmetic thing: it is customary to leave an empty line between changelog entries. Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
