https://bugzilla.redhat.com/show_bug.cgi?id=1725711



--- Comment #3 from Miro HronĨok <[email protected]> ---
> Package is approved

Thank you!

> 1. Please file a bug against xsimd (*) for the ExcludeArch use and make this
> block the relevant arch exclude trackerbugs (F-ExcludeArch-ARM, etc).

ack.

> 2. The package does not own %{_libdir}/cmake; nor does it have a "Requires:
> cmake-filesystem" potentially leaving an empty %{_libdir}/cmake behind after
> uninstall. cmake-filesystem is a bit of a bug-hammer, so I think it might be
> best to make the package co-own %{_libdir}/cmake. Or you could even leave
> this as is, it is not a big problem.

Actually, I've made it own %{_libdir}/cmake (to avoid a unnecessary dependency
on cmake), but I've realized that the dependency is automatically added by
/usr/lib/rpm/cmake.req RPM dependency generator:

$ rpm -qp --requires xsimd-devel-7.2.3-1.fc31.x86_64.rpm 
cmake-filesystem(x86-64)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to