https://bugzilla.redhat.com/show_bug.cgi?id=1726742



--- Comment #6 from David Moreau Simard <[email protected]> ---
(In reply to Miro HronĨok from comment #4)
> %{?python_provide:%python_provide python3-%{srcname}}
> 
> This will eventually provide python-python-box. is that intended?
>

It's not. The project on PyPi is python-box and on GitHub it's box.
I suppose we don't need a "box" package and only a "python3-box" package.

> 
> I suggest using tagged license source:
> https://raw.githubusercontent.com/cdgriffith/Box/%{version}/LICENSE

Sure.

> 
> Have you asked upstream to include it in sdist?
> 

I had not but I just opened an issue about it:
https://github.com/cdgriffith/Box/issues/92

> 
> BuildRequires:  python3-pytest-runner
> 
> But no %check, why?

Because the project won't install without it:
https://github.com/cdgriffith/Box/blob/3d221d7b33c1138a6c732a45ac943b201bd7fea2/setup.py#L36

I would like to add a %check macro eventually but I have time constraints right
now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to