https://bugzilla.redhat.com/show_bug.cgi?id=1731583



--- Comment #3 from Timothée Floure <[email protected]> ---
> Thanks for the quick review, Timothée. Please let me know if I can review 
> something for you in return. :)

Not right now but I'll keep it in mind. Thanks!

> Yes. We want to support F29 too.

A conditional and/or a comment would be nice so that an useless macro is not
forgotten for the next ten Fedora releases ;-)

> A missing BR: pytest-cov. Added it now. I verified in a virtual environment
that all tests pass. I'll enable them as soon as pytest-sugar is approved.

The pytest-cov issue is fixed but there is a failing test on my side, using
your python3-pytest-sugar package:
https://paste.sr.ht/~fnux/620bae68a1983798babcc943a726fc0f0d1c64aa

I believe you should remove `Documentation is available at
https://raphaelvallat.github.io/pingouin/build/html/index.html.` from the
description field: it is not relevant and the link is broken anyway.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to