https://bugzilla.redhat.com/show_bug.cgi?id=1738676
--- Comment #2 from Hirotaka Wakabayashi <hiw...@yahoo.com> --- Hello Robert-André, The License: field should be "MIT and CC0" because aes_test.go is under CC0. /usr/share/gocode/src/git.schwanenlied.me/yawning/bsaes.git/aes_test.go The package must contain a comment explaining the multiple licensing breakdown. Please see https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios LICENSE.txt must be included because bsaes-26d1add596b6d800bdeeb3bc3b2c7b316c056b6d.tar.gz includes bsaes/LICENSE.txt file. Please see https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text The followings are logs for reference. 1. rpmlint: ``` $ rpmlint -i /home/vagrant/rpmbuild/RPMS/noarch/golang-schwanenlied-yawning-bsaes-devel-0-0.1.20190807git26d1add.fc31.noarch.rpm golang-schwanenlied-yawning-bsaes-devel.noarch: W: spelling-error %description -l en_US aes -> eyes, sea, as The value of this tag appears to be misspelled. Please double-check. golang-schwanenlied-yawning-bsaes-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/git.schwanenlied.me/yawning/bsaes.git/.goipath The file or directory is hidden. You should see if this is normal, and delete it from the package if not. 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint -i /home/vagrant/rpmbuild/SRPMS/golang-schwanenlied-yawning-bsaes-0-0.1.20190807git26d1add.fc31.src.rpm golang-schwanenlied-yawning-bsaes.src: W: spelling-error %description -l en_US aes -> eyes, sea, as The value of this tag appears to be misspelled. Please double-check. golang-schwanenlied-yawning-bsaes.src: W: no-%build-section The spec file does not contain a %build section. Even if some packages don't directly need it, section markers may be overridden in rpm's configuration to provide additional "under the hood" functionality, such as injection of automatic -debuginfo subpackages. Add the section, even if empty. 1 packages and 0 specfiles checked; 0 errors, 2 warnings. ``` 2. Koji(success): http://koji.fedoraproject.org/koji/taskinfo?taskID=36893506 3. fedora-review ``` Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/vagrant/golang-schwanenlied-yawning-bsaes/golang-schwanenlied- yawning-bsaes/licensecheck.txt [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/doc/golang- schwanenlied-yawning-bsaes-devel(C, Failed, locale,, defaulting, to, set), /usr/share/gocode/src/git.schwanenlied.me(C, Failed, locale,, defaulting, to, set), /usr/share/gocode/src/git.schwanenlied.me/yawning(C, Failed, locale,, defaulting, to, set), /usr/share/gocode/src/git.schwanenlied.me/yawning/bsaes.git(C, Failed, locale,, defaulting, to, set), /usr/share/gocode/src/git.schwanenlied.me/yawning/bsaes.git/ct32(C, Failed, locale,, defaulting, to, set), /usr/share/gocode/src/git.schwanenlied.me/yawning/bsaes.git/ct64(C, Failed, locale,, defaulting, to, set), /usr/share/gocode/src/git.schwanenlied.me/yawning/bsaes.git/ghash(C, Failed, locale,, defaulting, to, set), /usr/share/gocode/src/git.schwanenlied.me/yawning/bsaes.git/internal(C, Failed, locale,, defaulting, to, set), /usr/share/gocode/src/git.schwanenlied.me/yawning/bsaes.git/internal/modes(C, Failed, locale,, defaulting, to, set) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: golang-schwanenlied-yawning-bsaes-devel-0-0.1.20190807git26d1add.fc31.noarch.rpm golang-schwanenlied-yawning-bsaes-0-0.1.20190807git26d1add.fc31.src.rpm golang-schwanenlied-yawning-bsaes-devel.noarch: W: spelling-error %description -l en_US aes -> eyes, sea, as golang-schwanenlied-yawning-bsaes-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/git.schwanenlied.me/yawning/bsaes.git/.goipath golang-schwanenlied-yawning-bsaes.src: W: spelling-error %description -l en_US aes -> eyes, sea, as golang-schwanenlied-yawning-bsaes.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). golang-schwanenlied-yawning-bsaes-devel.noarch: W: spelling-error %description -l en_US aes -> eyes, sea, as golang-schwanenlied-yawning-bsaes-devel.noarch: W: invalid-url URL: https://git.schwanenlied.me/yawning/bsaes <urlopen error [Errno -2] Name or service not known> golang-schwanenlied-yawning-bsaes-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/git.schwanenlied.me/yawning/bsaes.git/.goipath 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Source checksums ---------------- https://git.schwanenlied.me/yawning/bsaes/archive/26d1add596b6d800bdeeb3bc3b2c7b316c056b6d.tar.gz#/bsaes-26d1add596b6d800bdeeb3bc3b2c7b316c056b6d.tar.gz : CHECKSUM(SHA256) this package : a5dbdd52955b26041dc26b250ee7e17256e96658583c4a9c179c4f4e027366d3 CHECKSUM(SHA256) upstream package : a5dbdd52955b26041dc26b250ee7e17256e96658583c4a9c179c4f4e027366d3 Requires -------- golang-schwanenlied-yawning-bsaes-devel (rpmlib, GLIBC filtered): go-filesystem Provides -------- golang-schwanenlied-yawning-bsaes-devel: golang(git.schwanenlied.me/yawning/bsaes.git) golang(git.schwanenlied.me/yawning/bsaes.git)(commit=26d1add596b6d800bdeeb3bc3b2c7b316c056b6d) golang(git.schwanenlied.me/yawning/bsaes.git/ct32) golang(git.schwanenlied.me/yawning/bsaes.git/ct32)(commit=26d1add596b6d800bdeeb3bc3b2c7b316c056b6d) golang(git.schwanenlied.me/yawning/bsaes.git/ct64) golang(git.schwanenlied.me/yawning/bsaes.git/ct64)(commit=26d1add596b6d800bdeeb3bc3b2c7b316c056b6d) golang(git.schwanenlied.me/yawning/bsaes.git/ghash) golang(git.schwanenlied.me/yawning/bsaes.git/ghash)(commit=26d1add596b6d800bdeeb3bc3b2c7b316c056b6d) golang(git.schwanenlied.me/yawning/bsaes.git/internal/modes) golang(git.schwanenlied.me/yawning/bsaes.git/internal/modes)(commit=26d1add596b6d800bdeeb3bc3b2c7b316c056b6d) golang-ipath(git.schwanenlied.me/yawning/bsaes.git) golang-ipath(git.schwanenlied.me/yawning/bsaes.git)(commit=26d1add596b6d800bdeeb3bc3b2c7b316c056b6d) golang-schwanenlied-yawning-bsaes-devel Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review --rpm-spec -n golang-schwanenlied-yawning-bsaes-0-0.1.20190807git26d1add.fc31.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Perl, fonts, Python, C/C++, R, PHP, Java, Haskell, Ocaml, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ``` Thanks in advance, Hirotaka Wakabayashi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
