Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=653407

Mamoru Tasaka <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #1 from Mamoru Tasaka <[email protected]> 2010-11-15 
13:15:17 EST ---
Some notes:

* License
-----------------------------------------------------
Overall: ASL 2.0

GPL+
./lib/hashery/ini.rb
./lib/hashery/linkedlist.rb

GPLv2 or Ruby
./lib/hashery/ostructable.rb
-----------------------------------------------------
  - The license tag should be "ASL 2.0 and GPL+ and (GPLv2 or Ruby)"

! Usability
  - It seems that hashery 1.3.0 gem is a bit broken
-----------------------------------------------------
[tasa...@localhost ~]$ irb
irb(main):001:0> require "rubygems"
ge=> true
irb(main):002:0> gem "hashery"
=> true
irb(main):003:0> require "hashery"
LoadError: no such file to load -- facets/basicobject
 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in
`gem_original_require'
 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
 from /usr/lib/ruby/gems/1.8/gems/hashery-1.3.0/lib/hashery/openobject.rb:1
 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in
`gem_original_require'
 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
 from /usr/lib/ruby/gems/1.8/gems/hashery-1.3.0/lib/hashery.rb:7
 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in
`gem_original_require'
 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
 from (irb):3
-----------------------------------------------------
    Currently I won't make this a blocker for this review request
    ( as requiring scripts under lib/hashery/ directly seems to work,]
      except for "lib/hashery/openobject.rb"), However would you contact the
upstream?

? Scripts under test/
  - How can scripts under test/ directory be used? (If some test programs can
    be executable, would you do some tests in %check?)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to