https://bugzilla.redhat.com/show_bug.cgi?id=1719008
--- Comment #19 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
Terje, could you submit the change for bs4 as PR in pagure? Then we know we are
talking about the same thing ;)
When I try to build python-beautifulsoup4-4.8.0-1.fc31.src.rpm with
python2-soupsieve-1.9.2-1.fc32.noarch, python3-soupsieve-1.9.2-1.fc32.noarch
installed in rawhide mock, tests fail with:
======================================================================
FAIL: test_nested_namespaces (tests.test_lxml.LXMLXMLTreeBuilderSmokeTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "bs4/testing.py", line 841, in test_nested_namespaces
self.assertEqual(doc, soup.encode())
AssertionError: '<?xml version="1.0" encoding="utf-8"?>\n<!DOCTYPE html PUBLIC
"-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd";>\n<parent
xmlns="http://ns1/";>\n<child xmlns="http://ns2/";
xmlns:ns3="http://ns3/";>\n<grandchild ns3:attr="value"
xmlns="http://ns4/"/>\n</child>\n</parent>' != '<?xml version="1.0"
encoding="utf-8"?>\n<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd";>\n<parent
xmlns:="http://ns1/";>\n<child xmlns:="http://ns2/";
xmlns:ns3="http://ns3/";>\n<grandchild ns3:attr="value"
xmlns:="http://ns4/"/>\n</child>\n</parent>'
======================================================================
FAIL: test_real_xhtml_document (tests.test_lxml.LXMLXMLTreeBuilderSmokeTest)
A real XHTML document should come out *exactly* the same as it went in.
----------------------------------------------------------------------
Traceback (most recent call last):
File "bs4/testing.py", line 830, in test_real_xhtml_document
soup.encode("utf-8"), markup)
AssertionError: '<?xml version="1.0" encoding="utf-8"?>\n<!DOCTYPE html PUBLIC
"-//W3C//DTD XHTML 1.0 Transitional//EN">\n<html
xmlns:="http://www.w3.org/1999/xhtml";>\n<head><title>Hello.</title></head>\n<body>Goodbye.</body>\n</html>'
!= '<?xml version="1.0" encoding="utf-8"?>\n<!DOCTYPE html PUBLIC "-//W3C//DTD
XHTML 1.0 Transitional//EN">\n<html
xmlns="http://www.w3.org/1999/xhtml";>\n<head><title>Hello.</title></head>\n<body>Goodbye.</body>\n</html>'
----------------------------------------------------------------------
And the failure seems valid:
>>> print(s1)
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd";>
<parent xmlns="http://ns1/";>
<child xmlns="http://ns2/"; xmlns:ns3="http://ns3/";>
<grandchild ns3:attr="value" xmlns="http://ns4/"/>
</child>
</parent>
>>> print(s2)
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd";>
<parent xmlns:="http://ns1/";>
<child xmlns:="http://ns2/"; xmlns:ns3="http://ns3/";>
<grandchild ns3:attr="value" xmlns:="http://ns4/"/>
</child>
</parent>
Note the xmlns:="..." assignments.
That said, I think we should build python-soupsieve in rawhide, i.e. do the
step 1. from the list in previous comment.
@Miro, could you approve the package? We'll figure out the test failures later.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
