https://bugzilla.redhat.com/show_bug.cgi?id=1745368



--- Comment #2 from Fabio Valentini <[email protected]> ---
(In reply to Robert-André Mauchin from comment #1)
>  - Latest version is 2.2.0 (from 8 hours ago)

Thanks for the review!
I'll update the package to the latest version before importing.

>  - MIT and Boost
> 
> Boost Software License 1.0
> --------------------------
> sassc-2.1.0/ext/libsass/src/utf8.h
> sassc-2.1.0/ext/libsass/src/utf8/checked.h
> sassc-2.1.0/ext/libsass/src/utf8/core.h
> sassc-2.1.0/ext/libsass/src/utf8/unchecked.h
> 
>  Add a comment explaining the breakdown
> 
> Package approved. Please fix the aforementioned issues before import.

The binary extension is not built or included in the package at all.
The "sed" invocations in %prep and %build disable building the bundled libsass,
and make the ruby code load libsass from the "host" libsass package.

"%exclude %{gem_instdir}/ext/" prevents any files from the "ext" directory from
being included in the binary RPM, so I don't think I need to add "Boost" to the
License tag. Am I wrong?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to