https://bugzilla.redhat.com/show_bug.cgi?id=1745846



--- Comment #13 from Miro Hrončok <[email protected]> ---
(In reply to Luya Tshimbalanga from comment #12)
> (In reply to Miro Hrončok from comment #10)
> > Package should install a .desktop file using desktop-file-install or run
> > desktop-file-validate.
> 
> The .desktop file is specific to KDE Plasma as provided by KDE SIG
> themselves.

Does that mean it doesn't need to be validated? Why not?

https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files

"It is not simply enough to just include the .desktop file in the package, one
MUST run desktop-file-install (in %install) OR desktop-file-validate (in %check
or %install) and have BuildRequires: desktop-file-utils, to help ensure
.desktop file safety and spec-compliance."



> > Package must own all directories that it creates.
> > Directories without known owners: 
> >      /usr/share/wallpapers
> >      /usr/share/gnome-background-properties
> >      /usr/share/backgrounds/f31
> > 
> 
> Weird. Something is not right on the fedora-review. The spec file clearly
> lists:
> 
> %dir %{_datadir}/backgrounds/%{bgname}
> %dir %{_datadir}/gnome-background-properties/
> 
> which should set to the right owners. The ownership of
> "/usr/share/wallpapers" should be set to KDE using their macro
> %{_kde4_datadir}.
> It seems like a bug.

OK, let me recheck:

/usr/share/backgrounds/f31 is owned by f31-backgrounds-base
/usr/share/gnome-background-properties is owned by f31-backgrounds-gnome
/usr/share/wallpapers is owned by kde-filesystem

Mea cupla, everything is indeed alright there.


Downloading SRPM to check the remaining two.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to