https://bugzilla.redhat.com/show_bug.cgi?id=1739816
--- Comment #7 from Robert-André Mauchin <zebo...@gmail.com> ---
(In reply to Ege Güneş from comment #6)
> (In reply to Robert-André Mauchin from comment #5)
> > - That's not needed, the file should be in licensedir
> >
> > %{_docdir}/redminecli/LICENSE
> >
>
> The setup.py script tries to install license to `sys.prefix` (`/usr`) if
> include it in the dist. I couldn't see any macro that points to default
> licensedir. Can you point me the right direction?
mv it to %{_defaultlicensedir} if needed or exclide it with %exclude
>
> > - You haven't added the tests?
>
> Tests confused me because Python Packaging Docs[1] explicitly says "Python
> modules must not download any dependencies during the build process.". But I
> need to download the packages' dependencies to test it? Am I missing
> something?
>
> [1]
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
> #_reviewer_checklist
If there is some needed deps, add them as BR. But I ran the tests with no
issues without any added BR:
+ /usr/bin/python3 -m pytest
============================= test session starts
==============================
platform linux -- Python 3.8.0b3, pytest-4.6.5, py-1.8.0, pluggy-0.12.0
rootdir: /builddir/build/BUILD/redminecli-1.1.4
collected 20 items
tests/api/test_fetch.py ..... [ 25%]
tests/api/test_get.py .......... [ 75%]
tests/ui/test_priority.py . [ 80%]
tests/ui/test_project.py . [ 85%]
tests/ui/test_query.py . [ 90%]
tests/ui/test_tracker.py . [ 95%]
tests/ui/test_user.py . [100%]
========================== 20 passed in 0.72 seconds
===========================
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
