https://bugzilla.redhat.com/show_bug.cgi?id=1326504

Dave Love <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([email protected]
                   |                            |m)



--- Comment #15 from Dave Love <[email protected]> ---
Adam: can you still review this?

From a quick look:

licensecheck says Expat rather than MIT -- I haven't checked

You could use %make_build in %build

Remove the obsolete rm -rf from %install

To support EPEL, use %ldconfig_scriptlets instead of %post...

The library needs sorting out.  Its soname is libhts.so.2, but
it's installed as libhts.so.1.9 with a symlink to libhts.so.2.  I
haven't checked what's going on.  The %files entry for it should
be libhts.so.2*, so you know if it changes.  If the version is
actually taken from the release version -- I dont know -- it
shouldn't be, and could be set to 0 for Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to