https://bugzilla.redhat.com/show_bug.cgi?id=1750045
--- Comment #4 from Robert-André Mauchin <[email protected]> --- (In reply to Danishka Navin from comment #2) > Robert, Thanks for taking this package to review. > > (In reply to Robert-André Mauchin from comment #1) > > - Not a valid license shourthand, it should be "OFL": > > > > License: SIL Open Font License > > > > > Ok, I will make it as OFL > > > - Use a better name for your archive: > > > > Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz > > > > - What is this: > > > > %undefine _disable_source_fetch > > without this rpmbuild looking for the source file in my local. > That's normal and expected. Besides it won't work within Mock/Koji. You can use spectool -g to download the sources: spectool -g *.spec And mockbuild to test your package in a chroot: fedpkg --release f32 mockbuild --mock-config fedora-rawhide-x86_64 (In reply to Danishka Navin from comment #3) > Btw, I have originally used fontname as abhaya-libre-font as the upstream > also use the same name. > > But when I build the package there was an error > > >error: line 57: %files -n abhaya-libre-fonts > >: package abhaya-libre-fonts does not exist > > > So, I renamed it as abhaya-libre-fonts > In order to use a source from upstream, I used the following URL. > Source0: > https://github.com/mooniak/abhaya-libre-font/archive/v1.060.tar.gz Then the correct way to extract the archive should be: %autosetup -n abhaya-libre-font-%{version} Please post updated SPEC/SRPM -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
