https://bugzilla.redhat.com/show_bug.cgi?id=1747552
--- Comment #7 from Robert-André Mauchin <zebo...@gmail.com> ---
(In reply to Tulio Magno Quites Machado Filho from comment #6)
> (In reply to Robert-André Mauchin from comment #5)
> > You haven't addressed the follozwing:
> >
> > - Missing isa in %package devel
> >
> > Requires: %{name}%{?_isa} = %{version}-%{release}
>
> I can't find this line:
> $ git grep -En '^Requires:'
> libdfp.spec:41:Requires: %{name} = %{version}-%{release}
>
> What am I missing?
Line 41 Add %{?_isa} after %{name}
>
> > - It seems it should be:
> >
> > %prep
> > %autosetup -p1 -n %{name}-%{version}
> >
> >
> > - Not needed: %defattr(-,root,root,-) in %files devel
>
> Oops. Sorry. I fixed both issues now.
> I decided to drop -n completely because the current package from upstream
> conforms to the %{name}-%{version} as expected by RPM. Is that OK?
>
It's good.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
