https://bugzilla.redhat.com/show_bug.cgi?id=1768090



--- Comment #7 from Richard Shaw <[email protected]> ---
(In reply to Richard Shaw from comment #4)
> (In reply to Antonio from comment #2)
> > === Issues ===
> > 
> > - Sub-package are installed without license file except
> > 'opencascade-foundation'
> 
> All the other packages should require the foundation package but I'll double
> check.

Verified, all subpackages require opencascade-foundation


> > - '-Wl,--as-needed' are linker flags already included for packaging:
> > 
> > $ rpm --eval %__global_ldflags
> > -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now
> > -specs=/usr/lib/rpm/redhat/redhat-hardened-ld
> > 
> > Any reason for unsetting default linker flags? 
> > 
> > # Stop excessive linking that cmake projects are prone to.
> > export LDFLAGS="-Wl,--as-needed"
> 
> This is all left over from the OCE package, I can remove it.

Removed.


> > 
> > - Please, remove macros in the comments.

I made them '%%' instead until I think of a better way of handling it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to