https://bugzilla.redhat.com/show_bug.cgi?id=1768192



--- Comment #6 from Kees de Jong <kees.dejong+...@neobits.nl> ---
(In reply to Elliott Sales de Andrade from comment #4)
> The links you've used go to a GitHub webpage; they need to point directly to
> the raw file. Use the Download button on GitHub to get it.
> 
> In the Makefile, PREFIX is set using ?=, which means it should only be set
> if undefined. So setting it on the command-line would override (or rather,
> skip setting) the value from the file. But you'd need to override PREFIX for
> both %build and %install to work.

Perfect! Thanks for your help, it indeed works when the prefix is overridden in
both stages.

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=38853301
Spec URL:
https://raw.githubusercontent.com/AquaL1te/git-secrets/master/git-secrets.spec
SRPM URL:
https://github.com/AquaL1te/git-secrets/raw/master/git-secrets-1.3.0-1.fc30.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to