https://bugzilla.redhat.com/show_bug.cgi?id=1770898

Miro Hrončok <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #2 from Miro Hrončok <[email protected]> ---
Shoulds (highly recommended):

1. Group: is deprecated and SHOULD NOT be used.

2. The software uses setuptools, but the build dependency is not declared. It
is transitively pulled in, but that should not be relied upon.


Suggestions (totally optional):

3. Source0 could include %{name} instead of harcoded value.

4. See the
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_python_spec_file
about how to not duplicate %description (although, here the descriptions are a
bit different for no obvious reason).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to