https://bugzilla.redhat.com/show_bug.cgi?id=1768027

Vít Ondruch <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Vít Ondruch <[email protected]> ---
* Wrong use of PREFIX in install section
  - Usage of '/usr' is definitely not right. If nothing else, there should be
used %{_prefix} macro for this purpose
  - I have not looked into the project, but wouldn't be better to override the
DESTDIR?

* Bundled libwaive
  - It appears that at leas in upstream repository, there is bundled libwaive.
Would it be possible to unbundle this library? If not, there should be bundled
provide [1] in .spec file mentioning this library.




[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to