https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #12 from Richard W.M. Jones <[email protected]> --- Spec URL: http://oirase.annexia.org/reviews/virt-v2v/virt-v2v.spec SRPM URL: http://oirase.annexia.org/reviews/virt-v2v/virt-v2v-1.41.8-3.fc31.src.rpm Description: Convert a virtual machine to run on KVM Fedora Account System Username: rjones * Wed Nov 27 2019 Richard W.M. Jones <[email protected]> - 1.41.8-3 - Use license instead of doc for COPYING file. - Include license in all subpackages. - Add ?_isa to subpackage Requires. - Use gpgverify macro. - Don't own bash-completion directory because we Require the bash-completion package which owns it already. > (2) License file is not included when you install debuginfo (or any > other sub-packages). I've added it to all the subpackages that we control, but I don't believe it's possible to add it to the debuginfo package since that is completely generated by RPM itself. > (4) Seems like documentation size is 30720 bytes in 1 files. Needs a > separate -doc subpackage? 30K isn't particularly large. The rpmlint guideline is documentation larger than 1MB. The virt-v2v binary is 5MB. But the big advantage of including the docs in the main package is that people won't have any excuse not to read them! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
