https://bugzilla.redhat.com/show_bug.cgi?id=1770147



--- Comment #9 from Robert-AndrĂ© Mauchin <[email protected]> ---
The SELINUX scriptlets are not ok either, it should go likes this:

%post
if [ "$1" -le "1" ] ; then # First install
semodule -i %{_datadir}/selinux/packages/ntsclient.pp 2>/dev/null || :
fi

%preun
if [ "$1" -lt "1" ] ; then # Final removal
semodule -r ntsclient 2>/dev/null || :
fi

%postun
if [ "$1" -ge "1" ] ; then # Upgrade
semodule -i %{_datadir}/selinux/packages/ntsclient.pp 2>/dev/null || :
fi

 No need for setcap or restorecon here normally, this is handled by file
triggers I believe.

Also you are missing some BR for this:

BuildRequires: selinux-policy-devel
Requires(post): policycoreutils
Requires(preun): policycoreutils
Requires(postun): policycoreutils

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to