https://bugzilla.redhat.com/show_bug.cgi?id=1778530

Daiki Ueno <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
              Flags|                            |needinfo?([email protected])



--- Comment #3 from Daiki Ueno <[email protected]> ---
(In reply to Gary Buhrmaster from comment #2)

Thank you for the update; the updated spec looks good to me. I realized that I
missed that the FE-NEEDSPONSOR flag was set while I don't have the privilege.
Tomas, could you take a look perhaps?

> >  I'm also not sure if this explicit naming is ok; I would rather
> >  use libfido2-tools.
> 
> I selected the name to be compatible with the debian packages that upstream
> provides.  My initial thought was name compatibility was likely desirable to
> try to minimize unnecessary distro differences.  If you prefer
> libfido2-tools I can make that change, but I have not for this spec update.
> 
> I await further feedback.

Sounds reasonable to me.

> > - It would be good to bundle the gpg signature and verify it at %prep.
> 
> Currently the project does not sign releases.  I have opened an issue with
> the project requesting that they do include signatures for future releases.

I was referring to the Yubico's release page, where .sig is also provided:
https://developers.yubico.com/libfido2/Releases/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to