https://bugzilla.redhat.com/show_bug.cgi?id=1785391

Felix Schwarz <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Felix Schwarz <[email protected]> ---
just some random bikeshedding :-)

> Source0:        
> https://pypi.python.org/packages/source/s/spec/spec-%{version}.tar.gz

How about %pypi_source here? (%global srcname spec)
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_files_from_pypi

Also:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_python_provide_macro

> Requires:       python3-nose >= 1.3
> Requires:       python3-six

This might be picked up automatically in F30+


> %setup -q -n spec-%{version}

you may want to use:
%autosetup -n %{srcname}-%{version}

> %{python3_sitelib}/spec-%{version}-py?.?.egg-info/

This will break once we have Python 3.10. Packaging guide suggests:
%{python3_sitelib}/%{srcname}-*.egg-info/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to