https://bugzilla.redhat.com/show_bug.cgi?id=1789940

Robert-André Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Robert-André Mauchin <[email protected]> ---
 - Why the Epoch?

 - Why no parallel building?

make all → %make_build all

 - make install DESTDIR=%{buildroot} → %make_install

 - Don't use %{__install}, macro prefixed by __ are generally for rpm private
use

 - Please be more descriptive for the service description: 

"Pound user" → "User for the Pound reverse proxy and load balancer"

 - Why is there this stuff:

Requires(post):   systemd-sysv
Requires(post):   systemd-units
Requires(preun):  systemd-units
Requires(postun): systemd-units

 You just need BuildRequires: systemd-rpm-macros for Fedora.
 Not sure what it is on EPEL8, test BuildRequires: systemd-rpm-macros first
then if not available use BuildRequires: systemd-devel

 - https://www.apsis.ch/pound/ is 403? Isn't there another official site? Using
the fork as main page may be better: https://github.com/patrodyne/pound

 - License seems to include an exception:

License:     GPLv3 with exceptions

 - License mist be included with %license not %doc:

%files
%doc CHANGELOG FAQ README.md
%license GPL.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to