https://bugzilla.redhat.com/show_bug.cgi?id=1790838

[email protected] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #3 from [email protected] ---
I'll take a closer look during the weekend.

A few suggestions:
- use %make_build and %make_install instead of manual make invocations
- %ldconfig_scriptlets is obsolete and can be removed
- consider using %autosetup instead of %setup & %patch
- don't bump Release before the package is published
- where does the existing %changelog come from?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to