https://bugzilla.redhat.com/show_bug.cgi?id=1787619

Robert-André Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #5 from Robert-André Mauchin <[email protected]> ---
 - Please add a comment explaining why the patch is needed:

Patch0:         tucnak-4.18-soundwrapper.patch


 - Split your BR one per line is preferred

 - desktop-file-install %{buildroot}%{_datadir}/applications/%{name}.desktop →
desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop

 - build fails at configure:

********
Missing mandatory libraries:  libglib2
********
configure: error: missing mandatory library/libraries
error: Bad exit status from /var/tmp/rpm-tmp.qBKLsx (%build)  

 - BuildRequires:       libzia = %{version}
 → BuildRequires:       libzia-devel = %{version}

 - libizia-devel should Requires SDL-devel, please fix libizia package

In file included from /usr/include/libzia/zbat.h:15,
                 from /usr/include/libzia/libzia.h:21,
                 from header.h:38,
                 from alsa.c:13:
/usr/include/libzia/zsdl.h:17:10: fatal error: SDL.h: No such file or directory
   17 | #include <SDL.h>
      |          ^~~~~~~

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to