https://bugzilla.redhat.com/show_bug.cgi?id=1794912

Artur Iwicki <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #4 from Artur Iwicki <[email protected]> ---
># upstream doesn't ship manpage yet:
The man page is in the repo, it's just not included in the install script -
which you don't use either way, so I see no reason why not to install the man
page manually.

># %%{_mandir}/man1/nyancat.1.gz
Do not assume that man pages will be gzipped; use a wildcard that can match any
compression method (including no compression).
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages

>%doc
If it's gonna be empty, just remove it.

>%license
This should not be empty. Either ask upstream to provide a LICENCE file, or you
can use awk to extract the copyright header (and thus, the licence) from
src/nyancat.c:
$ awk '1;/\*\//{exit}' < src/nyancat.c > LICENSE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to