https://bugzilla.redhat.com/show_bug.cgi?id=1794564



--- Comment #1 from Hirotaka Wakabayashi <[email protected]> ---
Hello Michael,

Please see the comments.

1. Architecture
s390x should be listed in the spec in ExcludeArch if this package doesn't
support the s390x architecture. Please see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures

I found a build error on s390x architecture in a Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=41310129

2. python3-bt2's description
python3-bt2 package should have a descrption. Please see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description

3. License
The base package, which is "babeltrace2" in this case, should include the
upstream license file. Please see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming

This package should contain a comment explaining the multiple licensing
breakdown. Please see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios

Best Regards,
Hirotaka Wakabayashi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to