https://bugzilla.redhat.com/show_bug.cgi?id=1798811



--- Comment #2 from Aleksei Bavshin <[email protected]> ---
(In reply to Jan Staněk from comment #1)
> With github, there is no need to use the #-renaming trick for tarballs.
> Prefer `SourceN:  %{url}/archive/%{version}/%{name}-%{version}.tar.gz`.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_hosting_services
Noted, will be changed in next update.

> Maybe I'm missing something, but any service in Fedora is not enabled by 
> default;
Unfortunately user sevices are enabled by default. There's no global preset,
however there's a plan to add it in f32:
https://fedoraproject.org/wiki/Changes/Systemd_presets_for_user_units
I'm tracking that effort and will add proper conditionals once the change lands
into fedora-release for f32.
You are right though, I need to update a comment with a reference to that
change.

> Also, the unit file presumes the existence of a wayland-session.target,
> which we do not have in Fedora at the moment – so enabling the service would
> not have the desired effect of starting the service at login (as far as I
> can tell). I'm not sure what should be done with that.
I'll check that.
One thing I found with mako and redshift is that WantedBy=default.target starts
services too early and does not get environment from sway. Right now I'm using
custom sway-session.target and starting it from sway config as `exec 'systemctl
--user import-environment; systemctl --user start sway-session.target'`, but
that doesn't seem to be upstreamable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to