https://bugzilla.redhat.com/show_bug.cgi?id=1802177
--- Comment #6 from Fabio Valentini <[email protected]> --- This is much better, but there are still some mistakes: 1) The %changelog section is empty. If you want to have an automatically generated changelog entry for version 1.0.1, then I suggest setting Release to "0%{?dist}" and running $ rpmdev-bumpspec elementary-tweaks.spec --comment="Initial package for fedora." 2) The description is too long. Please wrap the description text to fit into 80 (or better, 72) columns, and end it with a full stop (it's a sentence, after all). 3) for %setup and %autosetup, %{name}-%{version} is the default if you don't specify any argument for "-n". Just drop "-n %{name}-%{version}", since that's redundant. 4) The package still owns too many directories. You should do something like this (I didn't check the actual filenames): %{_datadir}/icons/hicolor/*/apps/elementary-tweaks.svg And for the locale files, there's a %find_lang macro that must be used at the end of %install. There's documentation for that here: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_handling_locale_files 5) You don't need to maintain a fork to package this for fedora. You can instead use a git snapshot of the current upstream development status. Documentation for packaging git snapshots is available here: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_hosting_services Documentation for how to deal with pre-release snapshots is available here: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots Hope that helps. If you have any questions about how to apply those rules to your package, just ask. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]
