Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=655883 --- Comment #5 from Mohamed El Morabity <[email protected]> 2010-11-23 05:58:58 EST --- Please remove the useless versions conditions as explained in my first point for cmake and gtk2-devel: BuildRequires: gettext BuildRequires: cmake # No version condition needed BuildRequires: gtk2-devel # Here too BuildRequires: gtksourceview2-devel >= 2.10 BuildRequires: desktop-file-utils # Vala version 0.10.x (not above, not below) BuildRequires: vala >= 0.10.0 BuildRequires: vala < 0.11 BuildRequires: libgee-devel BuildRequires: unique-devel BuildRequires: libX11-devel By the way, you can remove libX11-devel (already required by gtk2-devel), as well as gtk2-devel (already required by unique-devel and gtksourceview2-devel). You can do without a patch, not easy to track and maintain, for flags: you can delete the « set (CMAKE_C_FLAGS "-O2") » in CMakeLists.txt using sed in %prep: %prep %setup -q # Unset upstream CFLAGS sed -i '/set (CMAKE_C_FLAGS "-O2")/d' CMakeLists.txt And call cmake in %build like this: %build %cmake -DCMAKE_C_FLAGS:STRING="%{optflags}" . make VERBOSE=1 %{?_smp_mflags} You can add the TODO file in %doc, to keep users aware of future features and fixes. (In reply to comment #3) > Hello, I'm the main developer of latexila. > 2) Another solution is to include the C code generated with the right version > of Vala in the tarball. > > 3) Make a new release of latexila based on Vala 0.11 and above. These solutions are better than the first one, I'm not sure it would be relevant to maintain 2 vala stacks just for latexila « a priori ». The last one is probably the most reasonnable (and easiest for the package maintainer ^^). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
