https://bugzilla.redhat.com/show_bug.cgi?id=1797367
Petr Pisar <ppi...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar <ppi...@redhat.com> ---
Source0 and Url addresses are usable. Ok.
Source0 archive (SHA-256:
ab0c1c31cf7b694dd3c9a0707098f7483763d46b60799a7f496ea0588be46b7b) is original.
Ok.
Summary is Ok.
Description verified from README. Ok.
FIX: Add a fullstop character at the end of the description text.
License verified from README, and lib/File/LoadLines.pm. Ok.
No XS code, noarch BuildArch is Ok.
FIX: Build-require 'perl(Exporter)' (lib/File/LoadLines.pm:7).
FIX: Build-require 'perl(utf8)' (t/10-basic.t:8).
All tests pass. Ok.
$ rpmlint perl-File-LoadLines.spec
../SRPMS/perl-File-LoadLines-0.02-3.fc33.src.rpm
../RPMS/noarch/perl-File-LoadLines-0.02-3.fc33.noarch.rpm
sh: /usr/bin/python2: No such file or directory
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-File-LoadLines-0.02-3.fc33.noarch.rpm
drwxr-xr-x 2 root root 0 Feb 28 09:11
/usr/share/doc/perl-File-LoadLines
-rw-r--r-- 1 root root 152 Oct 29 2018
/usr/share/doc/perl-File-LoadLines/Changes
-rw-r--r-- 1 root root 807 Oct 26 2018
/usr/share/doc/perl-File-LoadLines/README
-rw-r--r-- 1 root root 2298 Feb 28 09:11
/usr/share/man/man3/File::LoadLines.3pm.gz
drwxr-xr-x 2 root root 0 Feb 28 09:11
/usr/share/perl5/vendor_perl/File
-rw-r--r-- 1 root root 5240 Oct 29 2018
/usr/share/perl5/vendor_perl/File/LoadLines.pm
A file layout and the permissions are Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-File-LoadLines-0.02-3.fc33.noarch.rpm | sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.30.1)
1 perl(:VERSION) >= 5.10.1
1 perl(base)
1 perl(Encode)
1 perl(Exporter)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.
$ rpm -q --provides -p
../RPMS/noarch/perl-File-LoadLines-0.02-3.fc33.noarch.rpm | sort -f | uniq -c
1 perl(File::LoadLines) = 0.02
1 perl-File-LoadLines = 0.02-3.fc33
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-File-LoadLines-0.02-3.fc33.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in Fedora 33
(https://koji.fedoraproject.org/koji/taskinfo?taskID=41979480). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct the 'FIX' items before building this package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
