https://bugzilla.redhat.com/show_bug.cgi?id=1808571

Miro Hrončok <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #5 from Miro Hrončok <[email protected]> ---
> Successfully tested with Python-3.9

Thanks for testing this.


Regarding:

pathfix.py -pn -i "%{__python3}"
%{buildroot}%{python3_sitelib}/cclib/scripts/ccframe.py
pathfix.py -pn -i "%{__python3}"
%{buildroot}%{python3_sitelib}/cclib/scripts/ccget.py
pathfix.py -pn -i "%{__python3}"
%{buildroot}%{python3_sitelib}/cclib/scripts/ccwrite.py
pathfix.py -pn -i "%{__python3}"
%{buildroot}%{python3_sitelib}/cclib/scripts/cda.py

chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/ccframe.py
chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/ccget.py
chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/ccwrite.py
chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/cda.py


Wouldn't it be better to drop the shebangs entirely? Or are the users of this
package expected to execute those files directly?



> %global with_check 1

Consider using a %bcond?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to