https://bugzilla.redhat.com/show_bug.cgi?id=1810902
--- Comment #4 from cli...@gmail.com --- @chedi > for the permission part "E: non-executable-script" I could be wrong but I > think this is due to the presence of the shebang in the bash files. As you will be sourcing those in your environment the shebang are unecessary and could safely be removed. You are right that they are unnecessary. However, e.g. https://www.shellcheck.net/ will give you a warning if they are not included so I just included them to satisfy the linting tool and I don't think they are harmful there, although you are right that they are not technically needed, so idk, it's your call, I can remove them if you tell me but I would personally like them to stay if possible. The permission error I can fix easily, there should really rather be 755 to make it the same as the other /usr/bin content The /usr/lib thing I think I do correctly because %{_libdir} expands to on /usr/lib64 on my machine but I would like to specifically place the library under /usr/lib because it is a noarch package. But it's true that according to this thread https://lists.fedoraproject.org/archives/list/packag...@lists.fedoraproject.org/thread/AWM3ND26Q26M5OVDONQCWZBAN6AKV3MD/ I could be using %{_prefix}/lib instead of /usr/lib. I will change it too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
