https://bugzilla.redhat.com/show_bug.cgi?id=1811485

Artur Iwicki <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Artur Iwicki <[email protected]> ---
>Release:        1.gitbbe83864%{?dist}
Snapshots must also include the commit date.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots

>Group:          Applications/Multimedia
The "Group:" tag is not used in Fedora.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

># Distribution-specific patch to use /bin/env python3 shebang
>Patch1:         patch-waf-for-python3.patch
Do not use /bin/env. Explicitly specify the interpreter. (The link below talks
mostly about packaged files, but still it's a good rule to follow.)
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines

>Source0:        non-20200307-gitbbe83864.tar.bz2
># sh non-snapshot.sh (rev>
>Source1:        non-snapshot.sh
Poking around the site a little, it seems you can download a snapshot directly
using a URL like this:
"https://git.tuxfamily.org/non/non.git/snapshot/non-${GIT_COMMIT_HASH}.tar.gz";.

Also, as far as I can see, non.tuxfamily.org supports HTTPS, so I'd suggest
switching all the links from http:// to https://.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to