https://bugzilla.redhat.com/show_bug.cgi?id=1809097
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |zbys...@in.waw.pl
Assignee|nob...@fedoraproject.org |zbys...@in.waw.pl
Flags| |fedora-review?
--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
Obsoletes is wrong: php-lessphp-0.5.0-11.fc32 is the latest, so you need
something like
Obsoletes: php-lessphp < 0.5.0+0
Including the version in the spec file name seems wrong.
+ package name is OK (please rename the spec file)
+ latest version
+ license is acceptable (MIT (or GPLv3))
+ license is specified correctly
+ build and installs OK
+ fedora-review and rpmlint seem happy
+ Provides/Requires/BuildRequires look OK
rpmlint says:
E: description-line-too-long C It is designed to be compatible with less.js
(https://lesscss.org/), and suitable
→ please wrap.
php-marcusschwarz-lesserphp.src:65: W: mixed-use-of-spaces-and-tabs (spaces:
line 1, tab: line 65)
$ /usr/bin/plessc
PHP Fatal error: Uncaught Error: Class 'lessc' not found in /usr/bin/plessc:47
Stack trace:
#0 {main}
thrown in /usr/bin/plessc on line 47
→ that doesn't seem right :(
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
