https://bugzilla.redhat.com/show_bug.cgi?id=1804683
Brendan Early <mymindst...@evermiss.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #5 from Brendan Early <mymindst...@evermiss.net> ---
> - Libraries do not follow naming conventions. I think the ones under
> qt5/plugins are fine, but I don't think that libkbolt is ok.
> See:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning
> - libkbolt should be a subpackage
> See:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_mixed_use_packages
>
> → Won't fix, libkbolt is a QML plugin, it's not meant to be used outside
> plasma-thunderbolt.
Sorry, I didn't notice the "this is not needed" exception for plugins in the
guidelines. I tried to find other kcm plugins putting libraries under /usr/lib.
I was only able to find kde-connect, which does version it's lib.
https://src.fedoraproject.org/rpms/kde-connect/blob/master/f/kde-connect.spec#_161
> - Package installs a %{name}.desktop using desktop-file-install or desktop-
> file-validate if there is such a file.
> → Won't fix, it's a service file for a KCM module, not for an application, it
> won't pass the validation
metadata.desktop passes validation with desktop-file-validate perfectly fine on
my system.
Approved. None of these blockers, but I still encourage you to ask upstream to
version the lib.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
